refactor: relocate composer autocomplete to shared AutocompletePopup#41050
refactor: relocate composer autocomplete to shared AutocompletePopup#41050ricardogarim wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41050 +/- ##
===========================================
- Coverage 70.16% 70.13% -0.04%
===========================================
Files 3361 3361
Lines 129690 129686 -4
Branches 22490 22473 -17
===========================================
- Hits 91000 90952 -48
- Misses 35378 35421 +43
- Partials 3312 3313 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ricardogarim
force-pushed
the
refactor/autocomplete-move
branch
from
a6eecf2 to
9159c5d
Compare
1 participant
Proposed changes (including videos or screenshots)
Relocates the message-box autocomplete engine (popup component, hooks, and option/config factory) from
views/room/composerto a sharedclient/components/AutocompletePopupmodule. Pure file move + import-path updates — no behavior change — so the engine can be reused by other inputs.Issue(s)
Steps to test or reproduce
Composer autocomplete (
@,#,:,+:,/,!) behaves exactly as before.Further comments
First of a 3-PR stack. The decouple (#40925) and the first consumer (#40926) build on top.